Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.17] Fix running recent query button #8281

Merged
merged 1 commit into from
Sep 23, 2024
Merged

[Backport 2.17] Fix running recent query button #8281

merged 1 commit into from
Sep 23, 2024
+11 −3

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 2f36eaf from #8252.

@github-actions @opensearch-changeset-bot
Fix running recent query button (#8252)
c4a4b88 
* Fix click on recent query switching language

Signed-off-by: abbyhu2000 <[email protected]>

* change to use uuid as identifier

Signed-off-by: abbyhu2000 <[email protected]>

* Changeset file for PR #8252 created/updated

---------

Signed-off-by: abbyhu2000 <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 2f36eaf)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot added discover for discover reinvent autocut Skip the changelog verification check on backports distinguished-contributor 2.17.1 labels Sep 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

@codecov Codecov
Copy link

codecov bot commented Sep 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 63.94%. Comparing base (aa42f67) to head (c4a4b88).
Report is 14 commits behind head on 2.17.

Files with missing lines Patch % Lines
...query_string/language_service/lib/recent_query.tsx 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             2.17    #8281      +/-   ##
==========================================
- Coverage   63.94%   63.94%   -0.01%     
==========================================
  Files        3737     3737              
  Lines       88769    88771       +2     
  Branches    13807    13807              
==========================================
- Hits        56767    56766       -1     
- Misses      31404    31407       +3     
  Partials      598      598
Flag Coverage Δ
Linux_1 29.95% <0.00%> (-0.01%) ⬇️
Linux_2 58.95% <ø> (ø)
Linux_3 ?
Linux_4 31.31% <0.00%> (-0.01%) ⬇️
Windows_1 29.96% <0.00%> (-0.01%) ⬇️
Windows_2 58.89% <ø> (ø)
Windows_3 40.30% <0.00%> (-0.01%) ⬇️
Windows_4 31.31% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kavilla
Copy link
Member

kavilla commented Sep 23, 2024

failures seem unrelated

@kavilla kavilla merged commit baee58c into 2.17 Sep 23, 2024
66 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavilla kavilla kavilla approved these changes

@sejli sejli sejli approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

Assignees
No one assigned
Labels
2.17.1 autocut Skip the changelog verification check on backports discover for discover reinvent distinguished-contributor failed changeset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kavilla @sejli